* [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas
@ 2017-09-27 16:30 Hoang Tran
2017-09-29 5:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hoang Tran @ 2017-09-27 16:30 UTC (permalink / raw)
To: netdev
Cc: Hoang Tran, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
linux-kernel
With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals
ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would
under-evaluate the ssthresh.
Signed-off-by: Hoang Tran <hoang.tran@uclouvain.be>
---
net/ipv4/tcp_vegas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c
index 218cfcc..ee113ff 100644
--- a/net/ipv4/tcp_vegas.c
+++ b/net/ipv4/tcp_vegas.c
@@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(tcp_vegas_cwnd_event);
static inline u32 tcp_vegas_ssthresh(struct tcp_sock *tp)
{
- return min(tp->snd_ssthresh, tp->snd_cwnd-1);
+ return min(tp->snd_ssthresh, tp->snd_cwnd);
}
static void tcp_vegas_cong_avoid(struct sock *sk, u32 ack, u32 acked)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas
2017-09-27 16:30 [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas Hoang Tran
@ 2017-09-29 5:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-29 5:07 UTC (permalink / raw)
To: tranviethoang.vn; +Cc: netdev, hoang.tran, kuznet, yoshfuji, linux-kernel
From: Hoang Tran <tranviethoang.vn@gmail.com>
Date: Wed, 27 Sep 2017 18:30:58 +0200
> With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals
> ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would
> under-evaluate the ssthresh.
>
> Signed-off-by: Hoang Tran <hoang.tran@uclouvain.be>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-29 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 16:30 [PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas Hoang Tran
2017-09-29 5:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).