* [PATCH] ath10k: spectral: Remove redundant check
@ 2017-10-14 9:41 Christos Gkekas
2017-10-27 13:49 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Christos Gkekas @ 2017-10-14 9:41 UTC (permalink / raw)
To: Kalle Valo, ath10k, linux-wireless, netdev, linux-kernel; +Cc: Christos Gkekas
Variable val is unsigned, so checking whether it is less than zero is
redundant.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/net/wireless/ath/ath10k/spectral.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c
index dd9cc09..2048b1e 100644
--- a/drivers/net/wireless/ath/ath10k/spectral.c
+++ b/drivers/net/wireless/ath/ath10k/spectral.c
@@ -406,7 +406,7 @@ static ssize_t write_file_spectral_count(struct file *file,
if (kstrtoul(buf, 0, &val))
return -EINVAL;
- if (val < 0 || val > 255)
+ if (val > 255)
return -EINVAL;
mutex_lock(&ar->conf_mutex);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ath10k: spectral: Remove redundant check
2017-10-14 9:41 [PATCH] ath10k: spectral: Remove redundant check Christos Gkekas
@ 2017-10-27 13:49 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-10-27 13:49 UTC (permalink / raw)
To: Christos Gkekas
Cc: ath10k, linux-wireless, netdev, linux-kernel, Christos Gkekas
Christos Gkekas <chris.gekas@gmail.com> wrote:
> Variable val is unsigned, so checking whether it is less than zero is
> redundant.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
d83c0d3293bb ath10k: spectral: remove redundant check in write_file_spectral_count()
--
https://patchwork.kernel.org/patch/10006335/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-27 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-14 9:41 [PATCH] ath10k: spectral: Remove redundant check Christos Gkekas
2017-10-27 13:49 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).