From: Koichiro Den <den@klaipeden.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
Subject: Re: [net-next 2/3] tcp: do not tcp_collapse once SYN or FIN found
Date: Sun, 15 Oct 2017 11:43:40 +0900 [thread overview]
Message-ID: <1508035420.29679.3.camel@klaipeden.com> (raw)
In-Reply-To: <1507995823.31614.57.camel@edumazet-glaptop3.roam.corp.google.com>
On Sat, 2017-10-14 at 08:43 -0700, Eric Dumazet wrote:
> On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote:
> > Since 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue")
> > applied, we no longer need to continue to search for the starting
> > point once we encounter FIN packet. Same reasoning for SYN packet
> > since commit 9d691539eea2d ("tcp: do not enqueue skb with SYN flag"),
> > that would help us with error message when actual receiving.
>
> Very confusing changelog or patch.
>
> What exact problem do you want to solve ?
>
>
That I thought as unnecessary search for the starting point. I am going to re-
read all to correct my misunderstanding.
Thank you.
next prev parent reply other threads:[~2017-10-15 2:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 7:27 [net-next 0/3] optimisations and reorganisations of tcp_collapse Koichiro Den
2017-10-14 7:27 ` [net-next 1/3] tcp: avoid useless copying and collapsing of just one skb Koichiro Den
2017-10-14 15:42 ` Eric Dumazet
2017-10-15 2:32 ` Koichiro Den
2017-10-14 7:27 ` [net-next 2/3] tcp: do not tcp_collapse once SYN or FIN found Koichiro Den
2017-10-14 15:43 ` Eric Dumazet
2017-10-15 2:43 ` Koichiro Den [this message]
2017-10-14 7:27 ` [net-next 3/3] tcp: keep tcp_collapse controllable even after processing starts Koichiro Den
2017-10-14 15:46 ` Eric Dumazet
2017-10-15 2:45 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508035420.29679.3.camel@klaipeden.com \
--to=den@klaipeden.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox