From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@redhat.com>
Subject: Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard'
Date: Wed, 01 Aug 2018 09:28:14 +0100
Message-ID: <15081.1533112094@warthog.procyon.org.uk>
References: <20180801073251.9808-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: dhowells@redhat.com, davem@davemloft.net,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-afs@lists.infradead.org
To: YueHaibing <yuehaibing@huawei.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180801073251.9808-1-yuehaibing@huawei.com>
Content-ID: <15080.1533112094.1@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

YueHaibing <yuehaibing@huawei.com> wrote:

>  		while (*pp) {
>  			parent = *pp;
> -			xcall = rb_entry(parent, struct rxrpc_call, sock_node);
>  			if (user_call_ID < call->user_call_ID)
>  				pp = &(*pp)->rb_left;
>  			else if (user_call_ID > call->user_call_ID)

No, this is an actual bug.  The if-conditions should be using xcall-> not
call->.

> -		sp = rxrpc_skb(skb);

Yeah, that's fine.

> -	did_discard = true;

Hmmm...  It looks like I intended something with this, but I don't remember
what now.  I think it can be removed.

David