* [PATCH net-next] tcp: Use pI6c in tcp tracepoint
@ 2017-10-16 21:24 David Ahern
2017-10-16 21:41 ` Cong Wang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Ahern @ 2017-10-16 21:24 UTC (permalink / raw)
To: netdev; +Cc: xiyou.wangcong, David Ahern
The compact form for IPv6 addresses is more user friendly than the full
version. For example:
compact: 2001:db8:1::1
full: 2001:0db8:0001:0000:0000:0000:0000:0004i
Update the tcp tracepoint to show the compact form.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
include/trace/events/tcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 3d1cbd072b7e..1ffab6d96e94 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -57,7 +57,7 @@ TRACE_EVENT(tcp_retransmit_skb,
}
),
- TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6 daddrv6=%pI6",
+ TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c",
__entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
__entry->saddr_v6, __entry->daddr_v6)
);
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] tcp: Use pI6c in tcp tracepoint
2017-10-16 21:24 [PATCH net-next] tcp: Use pI6c in tcp tracepoint David Ahern
@ 2017-10-16 21:41 ` Cong Wang
2017-10-16 21:45 ` David Ahern
2017-10-16 22:33 ` Alexei Starovoitov
2017-10-18 13:03 ` David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Cong Wang @ 2017-10-16 21:41 UTC (permalink / raw)
To: David Ahern; +Cc: Linux Kernel Network Developers
On Mon, Oct 16, 2017 at 2:24 PM, David Ahern <dsahern@gmail.com> wrote:
> The compact form for IPv6 addresses is more user friendly than the full
> version. For example:
> compact: 2001:db8:1::1
> full: 2001:0db8:0001:0000:0000:0000:0000:0004i
>
> Update the tcp tracepoint to show the compact form.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
I was planning to send a same patch based on your
suggestion, you are faster than me. ;)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tcp: Use pI6c in tcp tracepoint
2017-10-16 21:24 [PATCH net-next] tcp: Use pI6c in tcp tracepoint David Ahern
2017-10-16 21:41 ` Cong Wang
@ 2017-10-16 22:33 ` Alexei Starovoitov
2017-10-18 13:03 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Alexei Starovoitov @ 2017-10-16 22:33 UTC (permalink / raw)
To: David Ahern; +Cc: netdev, xiyou.wangcong
On Mon, Oct 16, 2017 at 02:24:02PM -0700, David Ahern wrote:
> The compact form for IPv6 addresses is more user friendly than the full
> version. For example:
> compact: 2001:db8:1::1
> full: 2001:0db8:0001:0000:0000:0000:0000:0004i
>
> Update the tcp tracepoint to show the compact form.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
nice improvement.
Acked-by: Alexei Starovoitov <ast@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tcp: Use pI6c in tcp tracepoint
2017-10-16 21:24 [PATCH net-next] tcp: Use pI6c in tcp tracepoint David Ahern
2017-10-16 21:41 ` Cong Wang
2017-10-16 22:33 ` Alexei Starovoitov
@ 2017-10-18 13:03 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-10-18 13:03 UTC (permalink / raw)
To: dsahern; +Cc: netdev, xiyou.wangcong
From: David Ahern <dsahern@gmail.com>
Date: Mon, 16 Oct 2017 14:24:02 -0700
> The compact form for IPv6 addresses is more user friendly than the full
> version. For example:
> compact: 2001:db8:1::1
> full: 2001:0db8:0001:0000:0000:0000:0000:0004i
>
> Update the tcp tracepoint to show the compact form.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-18 13:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-16 21:24 [PATCH net-next] tcp: Use pI6c in tcp tracepoint David Ahern
2017-10-16 21:41 ` Cong Wang
2017-10-16 21:45 ` David Ahern
2017-10-16 22:33 ` Alexei Starovoitov
2017-10-18 13:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).