From: Mohammed Gamal <mgamal@redhat.com>
To: netdev@vger.kernel.org, skhare@vmware.com, pv-drivers@vmware.com
Cc: linux-kernel@vger.kernel.org, cavery@redhat.com,
otubo@redhat.com, vkuznets@redhat.com,
Mohammed Gamal <mgamal@redhat.com>
Subject: [PATCH] vmxnet3: Use correct minimum MTU value
Date: Tue, 17 Oct 2017 16:33:43 +0200 [thread overview]
Message-ID: <1508250823-1954-1-git-send-email-mgamal@redhat.com> (raw)
Currently the vmxnet3 driver has a minimum MTU value of 60. Which
goes against the RFC791 spec which specifies it at 68.
Setting MTU to values between 60 <= MTU <= 67 causes the network
interface to lose its IP, and it fails to restart.
This sets the minimum value to ETH_MIN_MTU (68) which is compatible
with is according to spec.
Reported-by: Bo Yang <boyang@redhat.com>
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
---
drivers/net/vmxnet3/vmxnet3_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h
index c3a3164..4ad905a 100644
--- a/drivers/net/vmxnet3/vmxnet3_defs.h
+++ b/drivers/net/vmxnet3/vmxnet3_defs.h
@@ -749,7 +749,7 @@ struct Vmxnet3_DriverShared {
((vfTable[vid >> 5] & (1 << (vid & 31))) != 0)
#define VMXNET3_MAX_MTU 9000
-#define VMXNET3_MIN_MTU 60
+#define VMXNET3_MIN_MTU ETH_MIN_MTU
#define VMXNET3_LINK_UP (10000 << 16 | 1) /* 10 Gbps, up */
#define VMXNET3_LINK_DOWN 0
--
1.8.3.1
next reply other threads:[~2017-10-17 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:33 Mohammed Gamal [this message]
2017-10-18 7:15 ` [PATCH] vmxnet3: Use correct minimum MTU value Andrew Lunn
2017-10-20 6:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508250823-1954-1-git-send-email-mgamal@redhat.com \
--to=mgamal@redhat.com \
--cc=cavery@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).