From: Paolo Abeni <pabeni@redhat.com>
To: Martin KaFai Lau <kafai@fb.com>, Wei Wang <weiwan@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
Xin Long <lucien.xin@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree
Date: Wed, 18 Oct 2017 22:30:29 +0200 [thread overview]
Message-ID: <1508358629.2599.6.camel@redhat.com> (raw)
In-Reply-To: <20171018190513.dtoqpzjfyapo2iie@kafai-mbp.dhcp.thefacebook.com>
On Wed, 2017-10-18 at 12:05 -0700, Martin KaFai Lau wrote:
> Another thing (not limited to this case),
>
> Considering we have a limited size in the exception table now and
> the oldest one will get removed when the table is full,
> do we still need to purge this periodically in gc?
At least in some scenarios we have only a few entries in the exception
table.
> I would like to see the IPv6's gc eventually goes away.
>
> If we need to expire the pmtu value of a RTF_CACHE rt,
> can dst.expires be checked during the lookup (like what
> ipv4 is doing) and then remove it from the exception table?
Currently the gc also performs validation vs the related neigh for
GATEWAY dst. That looks potentially quite expensive, as we currently
have a per neighbour atomic refcount (e.g. if the same dst is cached on
different CPUs)
Cheers,
Paolo
next prev parent reply other threads:[~2017-10-18 20:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 17:40 [PATCH net-next 0/3] ipv6: fixes for RTF_CACHE entries Paolo Abeni
2017-10-17 17:40 ` [PATCH net-next 1/3] ipv6: fix route cache dump Paolo Abeni
2017-10-17 18:26 ` Wei Wang
2017-10-17 18:41 ` Eric Dumazet
2017-10-17 19:35 ` Paolo Abeni
2017-10-17 17:40 ` [PATCH net-next 2/3] ipv6: start fib6 gc on RTF_CACHE dst creation Paolo Abeni
2017-10-17 18:35 ` Wei Wang
2017-10-17 21:53 ` Martin KaFai Lau
2017-10-17 17:40 ` [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree Paolo Abeni
2017-10-17 18:58 ` Wei Wang
2017-10-17 20:02 ` Paolo Abeni
2017-10-17 20:48 ` Wei Wang
2017-10-18 13:03 ` Paolo Abeni
2017-10-18 17:56 ` Wei Wang
2017-10-18 19:05 ` Martin KaFai Lau
2017-10-18 20:30 ` Paolo Abeni [this message]
2017-10-17 21:52 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508358629.2599.6.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=kafai@fb.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).