netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ye Yin <hustcat@gmail.com>
To: davem@davemloft.net
Cc: willemb@google.com, edumazet@google.com, johannes.berg@intel.com,
	dcaratti@redhat.com, pabeni@redhat.com, f.fainelli@gmail.com,
	fw@strlen.de, soheil@google.com, dwindsor@gmail.com,
	elena.reshetova@intel.com, tom@quantonium.net, Jason@zx2c4.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Ye Yin <hustcat@gmail.com>, Wei Zhou <chouryzhou@gmail.com>
Subject: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed
Date: Thu, 26 Oct 2017 16:57:05 +0800	[thread overview]
Message-ID: <1509008225-19614-1-git-send-email-hustcat@gmail.com> (raw)

When run ipvs in two different network namespace at the same host, and one
ipvs transport network traffic to the other network namespace ipvs.
'ipvs_property' flag will make the second ipvs take no effect. So we should
clear 'ipvs_property' when SKB network namespace changed.

Signed-off-by: Ye Yin <hustcat@gmail.com>
Signed-off-by: Wei Zhou <chouryzhou@gmail.com>
---
 include/linux/skbuff.h | 7 +++++++
 net/core/skbuff.c      | 1 +
 2 files changed, 8 insertions(+)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 72299ef..d448a48 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3770,6 +3770,13 @@ static inline void nf_reset_trace(struct sk_buff *skb)
 #endif
 }
 
+static inline void ipvs_reset(struct sk_buff *skb)
+{
+#if IS_ENABLED(CONFIG_IP_VS)
+	skb->ipvs_property = 0;
+#endif
+}
+
 /* Note: This doesn't put any conntrack and bridge info in dst. */
 static inline void __nf_copy(struct sk_buff *dst, const struct sk_buff *src,
 			     bool copy)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 2465607..e140ba4 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4864,6 +4864,7 @@ void skb_scrub_packet(struct sk_buff *skb, bool xnet)
 	if (!xnet)
 		return;
 
+	ipvs_reset(skb);
 	skb_orphan(skb);
 	skb->mark = 0;
 }
-- 
1.7.12.4

             reply	other threads:[~2017-10-26  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26  8:57 Ye Yin [this message]
2017-10-28 10:33 ` [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed Julian Anastasov
2017-11-02 14:46   ` Simon Horman
2017-11-04 13:38     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509008225-19614-1-git-send-email-hustcat@gmail.com \
    --to=hustcat@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=chouryzhou@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=dwindsor@gmail.com \
    --cc=edumazet@google.com \
    --cc=elena.reshetova@intel.com \
    --cc=f.fainelli@gmail.com \
    --cc=fw@strlen.de \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=soheil@google.com \
    --cc=tom@quantonium.net \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).