From: Paolo Abeni <pabeni@redhat.com>
To: David Ahern <dsahern@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: breakage due to commit 6e617de84e ("net: avoid a full fib lookup when rp_filter is disabled")
Date: Fri, 27 Oct 2017 14:46:27 +0200 [thread overview]
Message-ID: <1509108387.2460.31.camel@redhat.com> (raw)
In-Reply-To: <248fe046-1f13-1a9e-b587-e16515395be5@gmail.com>
On Thu, 2017-10-26 at 21:50 -0600, David Ahern wrote:
> Your commit:
>
> commit 6e617de84e87d626d1e976fc30e1322239fd4d2d
> Author: Paolo Abeni <pabeni@redhat.com>
> Date: Wed Sep 20 18:26:53 2017 +0200
>
> net: avoid a full fib lookup when rp_filter is disabled.
>
> breaks a test case that uses a veth pair in the same network namespace
> but separate VRFs. This setup:
>
> vrf add vrf0 table 1001
> vrf add vrf1 table 1002
>
> ip link add virt01 type veth peer name virt10
> ip link set virt01 master vrf0
> ip link set virt10 master vrf1
>
> ip addr add 172.16.20.20/24 dev virt01
> ip link set virt01 up
>
> ip addr add 172.16.20.21/24 dev virt10
> ip link set virt10 up
>
> ping -c 1 -I vrf0 172.16.20.21
>
> fails due to:
>
> if (inet_lookup_ifaddr_rcu(net, src))
> return -EINVAL;
>
> in fib_validate_source.
Thank you for the report.
Please give me a little time to investigate the issue; unfortunately I
would not be able to work on this untill Monday.
Cheers,
Paolo
prev parent reply other threads:[~2017-10-27 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 3:50 breakage due to commit 6e617de84e ("net: avoid a full fib lookup when rp_filter is disabled") David Ahern
2017-10-27 12:46 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509108387.2460.31.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).