From: David Ahern <dsahern@gmail.com>
To: netdev@vger.kernel.org
Cc: jiri@mellanox.com, idosch@mellanox.com, johannes.berg@intel.com,
David Ahern <dsahern@gmail.com>
Subject: [PATCH v2 net-next 0/3] net: Allow non-fatal messages to be passed in extack
Date: Fri, 27 Oct 2017 17:37:11 -0700 [thread overview]
Message-ID: <1509151034-28278-1-git-send-email-dsahern@gmail.com> (raw)
There are many cases where networking subsystems throw non-fatal warning
messages that end up in dmesg / kernel log to which a user making the
change is completely oblivious. This set makes the extack facility
usable for returning such messages.
The case in point here is spectrum and adding FIB rules which causes an
offload abort. Make the use case more user friendly by letting the user
know that offload is no longer happening because of the rule change.
v2
- kept the offload abort in a work queue entry per Ido's comment
David Ahern (3):
netlink: Allow ext_ack to carry non-error messages
net: Add extack to fib_notifier_info
mlxsw: spectrum_router: Return extack message on abort due to fib
rules
.../net/ethernet/mellanox/mlxsw/spectrum_router.c | 108 +++++++++++++--------
include/net/fib_notifier.h | 1 +
net/core/fib_rules.c | 9 +-
net/ipv4/fib_trie.c | 13 ++-
net/ipv6/ip6_fib.c | 15 +--
net/netlink/af_netlink.c | 18 ++--
6 files changed, 99 insertions(+), 65 deletions(-)
--
2.1.4
next reply other threads:[~2017-10-28 0:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 0:37 David Ahern [this message]
2017-10-28 0:37 ` [PATCH v2 net-next 1/3] netlink: Allow ext_ack to carry non-error messages David Ahern
2017-10-28 0:37 ` [PATCH v2 net-next 2/3] net: Add extack to fib_notifier_info David Ahern
2017-10-28 13:54 ` Ido Schimmel
2017-10-28 0:37 ` [PATCH v2 net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules David Ahern
2017-10-28 14:03 ` Ido Schimmel
2017-11-01 2:51 ` [PATCH v2 net-next 0/3] net: Allow non-fatal messages to be passed in extack David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509151034-28278-1-git-send-email-dsahern@gmail.com \
--to=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=johannes.berg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).