From: Lipeng <lipeng321@huawei.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <salil.mehta@huawei.com>,
<lipeng321@huawei.com>
Subject: [PATCH net-next 3/6] net: hns3: fix a bug in hns3_driv_to_eth_caps
Date: Fri, 3 Nov 2017 12:18:27 +0800 [thread overview]
Message-ID: <1509682710-94908-4-git-send-email-lipeng321@huawei.com> (raw)
In-Reply-To: <1509682710-94908-1-git-send-email-lipeng321@huawei.com>
From: Fuyun Liang <liangfuyun1@huawei.com>
The value of link_modes.advertising and the value of link_modes.supported
is initialized to zero every time in for loop in hns3_driv_to_eth_caps().
But we just want to set specified bit for them. Initialization is
unnecessary. This patch fixes it.
Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
index 0e10a43..c7b8ebd 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
@@ -359,17 +359,12 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd,
if (!(caps & hns3_lm_map[i].hns3_link_mode))
continue;
- if (is_advertised) {
- ethtool_link_ksettings_zero_link_mode(cmd,
- advertising);
+ if (is_advertised)
__set_bit(hns3_lm_map[i].ethtool_link_mode,
cmd->link_modes.advertising);
- } else {
- ethtool_link_ksettings_zero_link_mode(cmd,
- supported);
+ else
__set_bit(hns3_lm_map[i].ethtool_link_mode,
cmd->link_modes.supported);
- }
}
}
--
1.9.1
next prev parent reply other threads:[~2017-11-03 4:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 4:18 [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command Lipeng
2017-11-03 4:18 ` [PATCH net-next 1/6] net: hns3: fix for getting autoneg in hns3_get_link_ksettings Lipeng
2017-11-03 4:18 ` [PATCH net-next 2/6] net: hns3: fix for getting advertised_caps " Lipeng
2017-11-03 4:18 ` Lipeng [this message]
2017-11-03 4:18 ` [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings Lipeng
2017-11-03 19:52 ` Florian Fainelli
2017-11-06 2:28 ` lipeng (Y)
2017-11-03 4:18 ` [PATCH net-next 5/6] net: hns3: add support for nway_reset Lipeng
2017-11-03 19:53 ` Florian Fainelli
2017-11-03 4:18 ` [PATCH net-next 6/6] net: hns3: fix a bug for phy supported feature initialization Lipeng
2017-11-03 12:37 ` [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command David Miller
2017-11-03 15:51 ` Andrew Lunn
2017-11-03 16:01 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509682710-94908-4-git-send-email-lipeng321@huawei.com \
--to=lipeng321@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).