From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] tcp: fix tcp_mtu_probe() vs highest_sack
Date: Fri, 03 Nov 2017 14:31:19 -0700
Message-ID: <1509744679.2849.66.camel@edumazet-glaptop3.roam.corp.google.com>
References: <20170921014620.GA20906@castle>
         <CANn89iKm6E6vJ6m81ULFZVoVO3B5-pshB0=wPdvYgbYS+Wg8eQ@mail.gmail.com>
         <1509430100.3828.12.camel@edumazet-glaptop3.roam.corp.google.com>
         <2215018.A8bqHMq06m@natalenko.name>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        Yuchung Cheng <ycheng@google.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Roman Gushchin <guro@fb.com>, netdev <netdev@vger.kernel.org>,
        Neal Cardwell <ncardwell@google.com>,
        Lawrence Brakmo <brakmo@fb.com>
To: Oleksandr Natalenko <oleksandr@natalenko.name>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f172.google.com ([209.85.223.172]:48596 "EHLO
        mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750772AbdKCVbX (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 3 Nov 2017 17:31:23 -0400
Received: by mail-io0-f172.google.com with SMTP id d66so9199498ioe.5
        for <netdev@vger.kernel.org>; Fri, 03 Nov 2017 14:31:23 -0700 (PDT)
In-Reply-To: <2215018.A8bqHMq06m@natalenko.name>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 2017-11-03 at 19:22 +0100, Oleksandr Natalenko wrote:
> Hi.
> 
> Thanks for the fix.
> 
> However, tcp_fastretrans_alert() warning case still remains open even with 
> this patch. Do I understand correctly that these are 2 different issues?
> 
> Currently, I use latest 4.13 stable kernel + this patch and still get:
> 
> WARNING: CPU: 1 PID: 736 at net/ipv4/tcp_input.c:2826 tcp_fastretrans_alert
> +0x7c8/


My patch only fixed the panics that you guys reported.

The warning issue in fastretrans is a separate problem,
we are still working on it, but at least the effects are not
catastrophic.