From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Tu Subject: [PATCH] ip_gre: fix ip-config error reported by lkp-robot Date: Tue, 7 Nov 2017 07:57:44 -0800 Message-ID: <1510070264-56415-1-git-send-email-u9012063@gmail.com> To: netdev@vger.kernel.org Return-path: Received: from mail-it0-f68.google.com ([209.85.214.68]:45447 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbdKGP54 (ORCPT ); Tue, 7 Nov 2017 10:57:56 -0500 Received: by mail-it0-f68.google.com with SMTP id n195so3016372itg.0 for ; Tue, 07 Nov 2017 07:57:55 -0800 (PST) Received: from sc9-mailhost3.vmware.com ([24.5.191.4]) by smtp.gmail.com with ESMTPSA id n135sm952176itg.29.2017.11.07.07.57.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Nov 2017 07:57:54 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: lkp-robot reports the following two errors: IP-Config: Failed to open gretap0 IP-Config: Failed to open erspan0 due to device's mac address is zero. Fix it by assigning a random Ethernet address. Signed-off-by: William Tu --- net/ipv4/ip_gre.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index c105a315b1a3..1529a44f6945 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -998,6 +998,9 @@ static int ipgre_tunnel_init(struct net_device *dev) dev->header_ops = &ipgre_header_ops; } + if (is_zero_ether_addr(dev->dev_addr)) + eth_hw_addr_random(dev); + return ip_tunnel_init(dev); } @@ -1222,6 +1225,9 @@ static int gre_tap_init(struct net_device *dev) dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; netif_keep_dst(dev); + if (is_zero_ether_addr(dev->dev_addr)) + eth_hw_addr_random(dev); + return ip_tunnel_init(dev); } -- 2.7.4