From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops Date: Wed, 08 Nov 2017 09:49:11 -0800 Message-ID: <1510163351.15768.29.camel@perches.com> References: <20171108171917.5965-1-vivien.didelot@savoirfairelinux.com> <20171108171917.5965-5-vivien.didelot@savoirfairelinux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn To: Vivien Didelot , netdev@vger.kernel.org Return-path: In-Reply-To: <20171108171917.5965-5-vivien.didelot@savoirfairelinux.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote: > The DSA switch VLAN ops pass the switchdev_trans structure down to the > drivers, but no one is using them and they aren't supposed to anyway. [] > diff --git a/include/net/dsa.h b/include/net/dsa.h [] > @@ -410,12 +410,10 @@ struct dsa_switch_ops { > */ > int (*port_vlan_filtering)(struct dsa_switch *ds, int port, > bool vlan_filtering); > - int (*port_vlan_prepare)(struct dsa_switch *ds, int port, > - const struct switchdev_obj_port_vlan *vlan, > - struct switchdev_trans *trans); > - void (*port_vlan_add)(struct dsa_switch *ds, int port, > - const struct switchdev_obj_port_vlan *vlan, > - struct switchdev_trans *trans); > + int (*port_vlan_prepare)(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_vlan *vlan); > + void (*port_vlan_add)(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_vlan *vlan); > int (*port_vlan_del)(struct dsa_switch *ds, int port, > const struct switchdev_obj_port_vlan *vlan); I think this bit is slightly worse. Mixing alignment styles seems odd. I think it's better to either align all the (*func) uses on a tabstop or none of them.