From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kir Kolyshkin" <kir@openvz.org>
Subject: Re: [net-next] tcp: allow drivers to tweak TSQ logic
Date: Sat, 11 Nov 2017 15:27:19 +0100 [thread overview]
Message-ID: <1510410439.12037.10.camel@sipsolutions.net> (raw)
In-Reply-To: <1510281664.2849.143.camel@edumazet-glaptop3.roam.corp.google.com>
Thanks Eric!
> We expect wifi drivers to set this field to smaller values (tests have
> been done with values from 6 to 9)
I suppose we should test each driver or so.
> They would have to use following template :
>
> if (skb->sk && skb->sk->sk_pacing_shift != MY_PACING_SHIFT)
> skb->sk->sk_pacing_shift = MY_PACING_SHIFT;
Hm. I wish we wouldn't have to do this on every skb, but perhaps it
doesn't matter that much.
> u16 sk_gso_max_segs;
> + u8 sk_pacing_shift;
I guess you tried to fill a hole, but weren't we saying that it would
be better in the same cacheline? Then again, perhaps both cachelines
are resident anyway, haven't looked at this now.
Unrelated to that, I think this is missing a documentation update since
the struct has kernel-doc comments.
johannes
next prev parent reply other threads:[~2017-11-11 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 2:41 [PATCH net-next] tcp: allow drivers to tweak TSQ logic Eric Dumazet
2017-11-11 14:27 ` Johannes Berg [this message]
2017-11-11 23:38 ` [net-next] " Eric Dumazet
2017-11-13 9:21 ` Johannes Berg
2017-11-12 14:35 ` Toke Høiland-Jørgensen
2017-11-11 23:54 ` [PATCH v2 net-next] " Eric Dumazet
2017-11-12 13:39 ` Neal Cardwell
2017-11-14 7:18 ` David Miller
2017-11-28 13:10 ` Felix Fietkau
2017-11-28 17:33 ` Eric Dumazet
2017-12-12 14:34 ` [PATCH net-next] net: sk_pacing_shift_update() helper Eric Dumazet
2017-12-13 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510410439.12037.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kir@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).