From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH] net: phy: realtek: fix RTL8211F interrupt mode Date: Sun, 12 Nov 2017 19:39:46 +0100 Message-ID: <1510511986.3550.183.camel@baylibre.com> References: <66991733-9d1a-dbd2-9857-bba1ffca1cf8@gmail.com> <3a460dee-e714-e430-ce34-44c55d8a7490@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , "open list:ARM/Amlogic Meson..." , Shengzhou Liu To: Florian Fainelli , Heiner Kallweit , "David S. Miller" , Andrew Lunn Return-path: Received: from mail-wr0-f175.google.com ([209.85.128.175]:49015 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbdKLSjt (ORCPT ); Sun, 12 Nov 2017 13:39:49 -0500 Received: by mail-wr0-f175.google.com with SMTP id 15so12565434wrb.5 for ; Sun, 12 Nov 2017 10:39:48 -0800 (PST) In-Reply-To: <3a460dee-e714-e430-ce34-44c55d8a7490@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2017-11-12 at 10:29 -0800, Florian Fainelli wrote: > Hi Heiner, > > On 11/12/2017 07:16 AM, Heiner Kallweit wrote: > > After commit b94d22d94ad22 "ARM64: dts: meson-gx: add external PHY > > interrupt on some platforms" ethernet stopped working on my Odroid-C2 > > which has a RTL8211F phy. > > > > It turned out that no interrupts were triggered. Further analysis > > showed the register INER can't be altered on page 0. > > Because register INSR needs to be accessed via page 0xa43 I assumed > > that register INER needs to be accessed via some page too. > > Some brute force check resulted in page 0xa42 being the right one. > > > > With this patch the phy is working properly in interrupt mode. > > What would be the appropriate Fixes: tag for that patch? Fixes: 3447cf2e9a11 ("net/phy: Add support for Realtek RTL8211F") Seems appropriate