[PATCH] qed: fix unnecessary call to memset cocci warnings

[PATCH] qed: fix unnecessary call to memset cocci warnings

[Vasyl Gomonovych]

Use kzalloc rather than kmalloc followed by memset with 0
drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1280:13-20: WARNING:
kzalloc should be used for dcbx_info, instead of kmalloc/memset
Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Originally was fixed in:
'commit 561ed23331df ("qed: fix kzalloc-simple.cocci warnings")'
But later warning was introduced in:
'commit 62289ba27558 ("qed: Fix possible system hang in the
dcbnl-getdcbx() path.")'

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index 8f6ccc0c39e5..9a1bd996a640 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct qed_hwfn *hwfn,
 {
 	struct qed_dcbx_get *dcbx_info;
 
-	dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
+	dcbx_info = kzmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
 	if (!dcbx_info)
 		return NULL;
 
-	memset(dcbx_info, 0, sizeof(*dcbx_info));
 	if (qed_dcbx_query_params(hwfn, dcbx_info, type)) {
 		kfree(dcbx_info);
 		return NULL;
-- 
1.9.1

Re: [PATCH] qed: fix unnecessary call to memset cocci warnings

[David Miller]

From: Vasyl Gomonovych <gomonovych@gmail.com>
Date: Wed, 15 Nov 2017 20:58:15 +0100

> @@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct qed_hwfn *hwfn,
>  {
>  	struct qed_dcbx_get *dcbx_info;
>  
> -	dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
> +	dcbx_info = kzmalloc(sizeof(*dcbx_info), GFP_ATOMIC);

Thanks for not even compile testing your patch.

Re: [PATCH] qed: fix unnecessary call to memset cocci warnings

[Vasyl Gomonovych]

Sorry.

[PATCH] qed: fix unnecessary call to memset cocci warnings

[Vasyl Gomonovych]

Use kzalloc rather than kmalloc followed by memset with 0

drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1280:13-20: WARNING:
kzalloc should be used for dcbx_info, instead of kmalloc/memset
Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index 8f6ccc0c39e5..cc9e0dfcee48 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct qed_hwfn *hwfn,
 {
 	struct qed_dcbx_get *dcbx_info;
 
-	dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
+	dcbx_info = kzalloc(sizeof(*dcbx_info), GFP_ATOMIC);
 	if (!dcbx_info)
 		return NULL;
 
-	memset(dcbx_info, 0, sizeof(*dcbx_info));
 	if (qed_dcbx_query_params(hwfn, dcbx_info, type)) {
 		kfree(dcbx_info);
 		return NULL;
-- 
1.9.1

Re: [PATCH] qed: fix unnecessary call to memset cocci warnings

[Andy Shevchenko]

On Fri, Nov 17, 2017 at 12:04 AM, Vasyl Gomonovych <gomonovych@gmail.com> wrote:
> Use kzalloc rather than kmalloc followed by memset with 0
>
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1280:13-20: WARNING:
> kzalloc should be used for dcbx_info, instead of kmalloc/memset
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

While this looks okay per se now, it would be good if you put version
of the patch and add a changelog to it.

I think no need to resend this one, just for your information.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> index 8f6ccc0c39e5..cc9e0dfcee48 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> @@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct qed_hwfn *hwfn,
>  {
>         struct qed_dcbx_get *dcbx_info;
>
> -       dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
> +       dcbx_info = kzalloc(sizeof(*dcbx_info), GFP_ATOMIC);
>         if (!dcbx_info)
>                 return NULL;
>
> -       memset(dcbx_info, 0, sizeof(*dcbx_info));
>         if (qed_dcbx_query_params(hwfn, dcbx_info, type)) {
>                 kfree(dcbx_info);
>                 return NULL;
> --
> 1.9.1
>



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] qed: fix unnecessary call to memset cocci warnings

[David Miller]

From: Vasyl Gomonovych <gomonovych@gmail.com>
Date: Thu, 16 Nov 2017 23:04:08 +0100

> Use kzalloc rather than kmalloc followed by memset with 0
> 
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1280:13-20: WARNING:
> kzalloc should be used for dcbx_info, instead of kmalloc/memset
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

This patch doesn't even apply.

Re: [PATCH] qed: fix unnecessary call to memset cocci warnings

[Vasyl Gomonovych]

It  doesn't apply becouse of identical one qed: use kzalloc instead of kmalloc and memset.