From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>
Cc: netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: DMA coalescing - ethtool vs. kernel
Date: Mon, 27 Nov 2017 10:32:48 -0800 [thread overview]
Message-ID: <1511807568.2996.2.camel@intel.com> (raw)
In-Reply-To: <20171123123158.l6tu6hq2wgdstj4v@unicorn.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Thu, 2017-11-23 at 13:31 +0100, Michal Kubecek wrote:
> Hello,
>
> while digging through the interface between ethtool and kernel,
> I noticed that ethtool commit 5dd7bfbc5079 ("ethtool: Add DMA
> Coalescing
> support") added new member dmac into struct ethtool_coalesce which is
> part of kernel UAPI but there is no kernel counterpart to this change
> in
> master, net or net-next tree.
>
> This doesn't cause any serious trouble as with userspace structure
> longer than kernel thinks, kernel would simply ignore the extra
> member
> so that the feature "only" doesn't work. But I doubt such change
> could
> be accepted to kernel side of the interface as new kernel would then
> overflow shorter structure passed by older ethtool. Stephen Hemminger
> mentioned the ABI compatibility issue when this patch was submitted:
>
> https://patchwork.ozlabs.org/patch/806049/#1757846
>
> Does it make sense to have ethtool feature without kernel
> counterpart?
You are correct Michal. It appears this was over looked when John
applied this patch to ethtool. We have dropped this change (as well as
the kernel side changes) for now.
John- please revert the change to add DMA coalescing in ethtool.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-27 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 12:31 DMA coalescing - ethtool vs. kernel Michal Kubecek
2017-11-27 18:32 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511807568.2996.2.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).