From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro Date: Tue, 28 Nov 2017 14:19:54 +0200 Message-ID: <1511871594.25007.464.camel@linux.intel.com> References: <20171123203605.44954-1-andriy.shevchenko@linux.intel.com> <20171123203605.44954-2-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: Johan Hedberg , "open list:BLUETOOTH DRIVERS" , "David S. Miller" , Network Development , Randy Dunlap To: Marcel Holtmann Return-path: In-Reply-To: Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, 2017-11-28 at 09:43 +0100, Marcel Holtmann wrote: > Hi Andy, > > > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current > > users, which are many of them, and for new comers to decrease code > > duplication. > can we define this in hci_debugfs.c first and get that patch merged > into bluetooth-next. And only as a follow up patch try to generalize > this in seq_file.h. I really don’t like to carry a patch for > seq_file.h in the bluetooth-next tree. > This was in v1 [1]. Feel free to apply it instead. Frankly I don't understand what's wrong with carrying patch against seq_file.h? Is it "person non grata"? [1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2 -- Andy Shevchenko Intel Finland Oy