netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>, Yotam Gigi <yotamg@mellanox.com>
Subject: Re: [Patch net v2] act_sample: get rid of tcf_sample_cleanup_rcu()
Date: Wed, 29 Nov 2017 19:11:24 -0800	[thread overview]
Message-ID: <1512011484.19682.8.camel@gmail.com> (raw)
In-Reply-To: <20171130000751.21929-1-xiyou.wangcong@gmail.com>

On Wed, 2017-11-29 at 16:07 -0800, Cong Wang wrote:
> Similar to commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu"),
> TC actions don't need to respect RCU grace period, because it
> is either just detached from tc filter (standalone case) or
> it is removed together with tc filter (bound case) in which case
> RCU grace period is already respected at filter layer.
> 
> Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jiri Pirko <jiri@resnulli.us>
> Cc: Yotam Gigi <yotamg@mellanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
>  include/net/tc_act/tc_sample.h |  1 -
>  net/sched/act_sample.c         | 14 +++-----------
>  2 files changed, 3 insertions(+), 12 deletions(-)
> 

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks !

  reply	other threads:[~2017-11-30  3:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  0:07 [Patch net v2] act_sample: get rid of tcf_sample_cleanup_rcu() Cong Wang
2017-11-30  3:11 ` Eric Dumazet [this message]
2017-11-30 15:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512011484.19682.8.camel@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).