From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [Patch net v2] act_sample: get rid of tcf_sample_cleanup_rcu()
Date: Wed, 29 Nov 2017 19:11:24 -0800
Message-ID: <1512011484.19682.8.camel@gmail.com>
References: <20171130000751.21929-1-xiyou.wangcong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>,
        Yotam Gigi <yotamg@mellanox.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f42.google.com ([74.125.83.42]:45865 "EHLO
        mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752960AbdK3DL1 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 29 Nov 2017 22:11:27 -0500
Received: by mail-pg0-f42.google.com with SMTP id m25so2418928pgv.12
        for <netdev@vger.kernel.org>; Wed, 29 Nov 2017 19:11:27 -0800 (PST)
In-Reply-To: <20171130000751.21929-1-xiyou.wangcong@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2017-11-29 at 16:07 -0800, Cong Wang wrote:
> Similar to commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu"),
> TC actions don't need to respect RCU grace period, because it
> is either just detached from tc filter (standalone case) or
> it is removed together with tc filter (bound case) in which case
> RCU grace period is already respected at filter layer.
> 
> Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jiri Pirko <jiri@resnulli.us>
> Cc: Yotam Gigi <yotamg@mellanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
>  include/net/tc_act/tc_sample.h |  1 -
>  net/sched/act_sample.c         | 14 +++-----------
>  2 files changed, 3 insertions(+), 12 deletions(-)
> 

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks !