From mboxrd@z Thu Jan 1 00:00:00 1970 From: Max Uvarov Subject: [PATCH] net: phy-micrel: check return code in flp center function Date: Thu, 30 Nov 2017 13:08:29 +0300 Message-ID: <1512036509-18924-1-git-send-email-muvarov@gmail.com> Cc: andrew@lunn.ch, f.fainelli@gmail.com, Max Uvarov To: netdev@vger.kernel.org Return-path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:38991 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbdK3KIo (ORCPT ); Thu, 30 Nov 2017 05:08:44 -0500 Received: by mail-lf0-f66.google.com with SMTP id l81so7241492lfl.6 for ; Thu, 30 Nov 2017 02:08:44 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Fix obvious typo that first return value is set but not checked. Signed-off-by: Max Uvarov --- drivers/net/phy/micrel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index fdb43dd..ab46141 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -496,16 +496,18 @@ static int ksz9031_of_load_skew_values(struct phy_device *phydev, return ksz9031_extended_write(phydev, OP_DATA, 2, reg, newval); } +/* Center KSZ9031RNX FLP timing at 16ms. */ static int ksz9031_center_flp_timing(struct phy_device *phydev) { int result; - /* Center KSZ9031RNX FLP timing at 16ms. */ result = ksz9031_extended_write(phydev, OP_DATA, 0, MII_KSZ9031RN_FLP_BURST_TX_HI, 0x0006); + if (result) + return result; + result = ksz9031_extended_write(phydev, OP_DATA, 0, MII_KSZ9031RN_FLP_BURST_TX_LO, 0x1A80); - if (result) return result; -- 2.5.0