From: wexu@redhat.com
To: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jasowang@redhat.com, mst@redhat.com, mjrosato@linux.vnet.ibm.com,
wexu@redhat.com
Subject: [PATCH net,stable v3] vhost: fix a few skb leaks
Date: Fri, 1 Dec 2017 00:54:26 -0500 [thread overview]
Message-ID: <1512107669-27572-1-git-send-email-wexu@redhat.com> (raw)
From: Wei Xu <wexu@redhat.com>
Matthew found a roughly 40% tcp throughput regression with commit
c67df11f(vhost_net: try batch dequing from skb array) as discussed
in the following thread:
https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
This is v3.
v3:
- move freeing skb from vhost to tun/tap recvmsg() to not
confuse the callers.
v2:
- add Matthew as the reporter, thanks matthew.
- moving zero headcount check ahead instead of defer consuming skb
due to jason and mst's comment.
- add freeing skb in favor of recvmsg() fails.
Wei Xu (3):
vhost: fix skb leak in handle_rx()
tun: free skb in early errors
tap: free skb if flags error
drivers/net/tap.c | 6 +++++-
drivers/net/tun.c | 14 +++++++++++---
drivers/vhost/net.c | 20 ++++++++++----------
3 files changed, 26 insertions(+), 14 deletions(-)
--
1.8.3.1
next reply other threads:[~2017-12-01 5:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 5:54 wexu [this message]
2017-12-01 5:54 ` [PATCH 1/3] vhost: fix skb leak in handle_rx() wexu
2017-12-01 7:11 ` Jason Wang
2017-12-01 14:37 ` Michael S. Tsirkin
2017-12-04 7:18 ` Jason Wang
2017-12-01 5:54 ` [PATCH 2/3] tun: free skb in early errors wexu
2017-12-01 7:07 ` Jason Wang
2017-12-01 14:36 ` Michael S. Tsirkin
2017-12-01 5:54 ` [PATCH 3/3] tap: free skb if flags error wexu
2017-12-01 7:10 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512107669-27572-1-git-send-email-wexu@redhat.com \
--to=wexu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).