From: David Lechner <david@lechnology.com>
To: devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org
Cc: David Lechner <david@lechnology.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] bluetooth: hci_ll: Add optional nvmem MAC address source
Date: Sun, 3 Dec 2017 21:21:22 -0600 [thread overview]
Message-ID: <1512357682-8911-4-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1512357682-8911-1-git-send-email-david@lechnology.com>
This adds an optional nvmem consumer to get a MAC address from an external
source. The MAC address is then set in the Bluetooth chip after the
firmware has been loaded.
This has been tested working with a TI CC2560A chip (in a LEGO MINDSTORMS
EV3).
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/bluetooth/hci_ll.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index 974a788..dd3b5c2 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -53,10 +53,12 @@
#include <net/bluetooth/bluetooth.h>
#include <net/bluetooth/hci_core.h>
#include <linux/gpio/consumer.h>
+#include <linux/nvmem-consumer.h>
#include "hci_uart.h"
/* Vendor-specific HCI commands */
+#define HCI_VS_WRITE_BD_ADDR 0xfc06
#define HCI_VS_UPDATE_UART_HCI_BAUDRATE 0xff36
/* HCILL commands */
@@ -89,6 +91,7 @@ struct ll_device {
struct serdev_device *serdev;
struct gpio_desc *enable_gpio;
struct clk *ext_clk;
+ u8 *bdaddr;
};
struct ll_struct {
@@ -698,6 +701,19 @@ static int ll_setup(struct hci_uart *hu)
if (err)
return err;
+ /* Set MAC address, if any */
+ if (lldev->bdaddr) {
+ struct sk_buff *skb;
+
+ skb = __hci_cmd_sync(hu->hdev, HCI_VS_WRITE_BD_ADDR, 6,
+ lldev->bdaddr, HCI_INIT_TIMEOUT);
+ if (IS_ERR(skb))
+ bt_dev_err(hu->hdev, "Failed to set MAC address (%ld)",
+ PTR_ERR(skb));
+ else
+ kfree_skb(skb);
+ }
+
/* Operational speed if any */
if (hu->oper_speed)
speed = hu->oper_speed;
@@ -726,6 +742,7 @@ static int hci_ti_probe(struct serdev_device *serdev)
{
struct hci_uart *hu;
struct ll_device *lldev;
+ struct nvmem_cell *bdaddr_cell;
u32 max_speed = 3000000;
lldev = devm_kzalloc(&serdev->dev, sizeof(struct ll_device), GFP_KERNEL);
@@ -747,6 +764,22 @@ static int hci_ti_probe(struct serdev_device *serdev)
of_property_read_u32(serdev->dev.of_node, "max-speed", &max_speed);
hci_uart_set_speeds(hu, 115200, max_speed);
+ /* optional MAC address from nvram */
+ bdaddr_cell = nvmem_cell_get(&serdev->dev, "mac-address");
+ if (IS_ERR(bdaddr_cell)) {
+ int err = PTR_ERR(bdaddr_cell);
+
+ if (err != -ENOENT) {
+ if (err != -EPROBE_DEFER)
+ dev_err(&serdev->dev,
+ "Failed to get \"mac-address\" nvmem cell\n");
+ return err;
+ }
+ } else {
+ lldev->bdaddr = nvmem_cell_read(bdaddr_cell, NULL);
+ nvmem_cell_put(bdaddr_cell);
+ }
+
return hci_uart_register_device(hu, &llp);
}
--
2.7.4
next prev parent reply other threads:[~2017-12-04 3:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 3:21 [PATCH 0/3] bluetooth: hci_ll: Get MAC address from NVMEM David Lechner
2017-12-04 3:21 ` [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st David Lechner
[not found] ` <1512357682-8911-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-04 6:50 ` Marcel Holtmann
2017-12-04 9:54 ` Sergei Shtylyov
[not found] ` <2dfb7130-e229-7429-0f30-11d7df553fdf-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-12-04 10:09 ` Sergei Shtylyov
2017-12-04 3:21 ` [PATCH 2/3] bluetooth: hci_ll: add constant for vendor-specific command David Lechner
[not found] ` <1512357682-8911-3-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-04 6:23 ` Marcel Holtmann
2017-12-07 21:29 ` David Lechner
2017-12-07 21:43 ` Marcel Holtmann
2017-12-04 3:21 ` David Lechner [this message]
[not found] ` <1512357682-8911-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-04 6:48 ` [PATCH 3/3] bluetooth: hci_ll: Add optional nvmem MAC address source Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512357682-8911-4-git-send-email-david@lechnology.com \
--to=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).