netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Ariel Elior <Ariel.Elior@cavium.com>,
	everest-linux-l2@cavium.com
Subject: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.
Date: Mon,  4 Dec 2017 06:12:47 -0500	[thread overview]
Message-ID: <1512385967-32339-5-git-send-email-michael.chan@broadcom.com> (raw)
In-Reply-To: <1512385967-32339-1-git-send-email-michael.chan@broadcom.com>

Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on
NETIF_F_GRO_FW flag.

Cc: Ariel Elior <Ariel.Elior@cavium.com>
Cc: everest-linux-l2@cavium.com
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 ++-------
 drivers/net/ethernet/qlogic/qede/qede_main.c   | 4 ++--
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index c1a0708..7ee49b4 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -901,13 +901,8 @@ int qede_set_features(struct net_device *dev, netdev_features_t features)
 	netdev_features_t changes = features ^ dev->features;
 	bool need_reload = false;
 
-	/* No action needed if hardware GRO is disabled during driver load */
-	if (changes & NETIF_F_GRO) {
-		if (dev->features & NETIF_F_GRO)
-			need_reload = !edev->gro_disable;
-		else
-			need_reload = edev->gro_disable;
-	}
+	if (changes & NETIF_F_GRO_HW)
+		need_reload = true;
 
 	if (need_reload) {
 		struct qede_reload_args args;
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 8f9b3eb..b81620e 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -676,7 +676,7 @@ static void qede_init_ndev(struct qede_dev *edev)
 	ndev->priv_flags |= IFF_UNICAST_FLT;
 
 	/* user-changeble features */
-	hw_features = NETIF_F_GRO | NETIF_F_SG |
+	hw_features = NETIF_F_GRO | NETIF_F_GRO_HW | NETIF_F_SG |
 		      NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
 		      NETIF_F_TSO | NETIF_F_TSO6;
 
@@ -1515,7 +1515,7 @@ static void qede_init_fp(struct qede_dev *edev)
 			 edev->ndev->name, queue_id);
 	}
 
-	edev->gro_disable = !(edev->ndev->features & NETIF_F_GRO);
+	edev->gro_disable = !(edev->ndev->features & NETIF_F_GRO_HW);
 }
 
 static int qede_set_real_num_queues(struct qede_dev *edev)
-- 
1.8.3.1

  parent reply	other threads:[~2017-12-04 11:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 11:12 [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW Michael Chan
2017-12-04 11:12 ` [PATCH net-next 1/4] net: " Michael Chan
2017-12-04 16:30   ` Or Gerlitz
2017-12-04 16:47   ` Alexander Duyck
2017-12-04 18:23     ` Michael Chan
2017-12-04 18:43       ` Alexander Duyck
2017-12-04 18:59         ` David Miller
2017-12-04 19:24           ` Alexander Duyck
2017-12-04 19:26           ` Eric Dumazet
2017-12-04 19:36             ` Alexander Duyck
2017-12-04 19:52         ` Michael Chan
2017-12-04 20:58           ` Alexander Duyck
2017-12-04 23:05             ` Michael Chan
2017-12-04 22:15   ` Yuval Mintz
2017-12-04 22:31     ` Michael Chan
2017-12-04 11:12 ` [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW Michael Chan
2017-12-04 16:35   ` Or Gerlitz
2017-12-04 18:11     ` Michael Chan
2017-12-04 21:06       ` Or Gerlitz
2017-12-04 22:00         ` Eric Dumazet
2017-12-05  0:07           ` Michael Chan
2017-12-05 18:10             ` Marcelo Ricardo Leitner
2017-12-06 21:04               ` Michael Chan
2017-12-04 11:12 ` [PATCH net-next 3/4] bnx2x: " Michael Chan
2017-12-04 11:12 ` Michael Chan [this message]
2017-12-04 21:48   ` [PATCH net-next 4/4] qede: " Yuval Mintz
2017-12-04 22:45     ` Michael Chan
2017-12-05 12:32       ` Chopra, Manish
2017-12-05 17:13         ` Michael Chan
2017-12-04 11:38 ` [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW Elior, Ariel
2017-12-05 19:31 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512385967-32339-5-git-send-email-michael.chan@broadcom.com \
    --to=michael.chan@broadcom.com \
    --cc=Ariel.Elior@cavium.com \
    --cc=davem@davemloft.net \
    --cc=everest-linux-l2@cavium.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).