netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: simo.ghannam@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] tcp/dccp: CVE-2017-8824: use-after-free in DCCP code
Date: Mon, 04 Dec 2017 12:48:28 -0800	[thread overview]
Message-ID: <1512420508.19682.63.camel@gmail.com> (raw)
In-Reply-To: <1512420060.19682.62.camel@gmail.com>

On Mon, 2017-12-04 at 12:41 -0800, Eric Dumazet wrote:
> On Mon, 2017-12-04 at 21:27 +0100, simo.ghannam@gmail.com wrote:
> > From: Mohamed Ghannam <simo.ghannam@gmail.com>
> > 
> > 	Whenever the sock object is in DCCP_CLOSED state,
> > dccp_disconnect() must free
> > 	 dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL.
> > 
> > Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com>
> > ---
> 
> Small nit : white spaces in changelog where not needed :
> 
> Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect()
> must free dccps_hc_tx_ccid and dccps_hc_rx_ccid and set them to NULL.
> 
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> 
> Thanks !
> 

Also patch title mentions tcp, but this is not a tcp fix, only dccp

[PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code

      reply	other threads:[~2017-12-04 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 20:27 [PATCH] tcp/dccp: CVE-2017-8824: use-after-free in DCCP code simo.ghannam
2017-12-04 20:41 ` Eric Dumazet
2017-12-04 20:48   ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512420508.19682.63.camel@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=simo.ghannam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).