From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.
Date: Mon, 04 Dec 2017 14:00:45 -0800
Message-ID: <1512424845.19682.64.camel@gmail.com>
References: <1512385967-32339-1-git-send-email-michael.chan@broadcom.com>
         <1512385967-32339-3-git-send-email-michael.chan@broadcom.com>
         <CAJ3xEMghbGNkE5N2+aCMJK_nc2Yivyj2FYnFagTf9nF8xrew6g@mail.gmail.com>
         <CACKFLik-yLSCPMyV__CfDZaZfLWCHo6x74-7bWT+Ox1cVJfMpA@mail.gmail.com>
         <CAJ3xEMg5rS+Q=1hV8aMBQJruOH1A7-dScp_8WZwUQTJ7CKcsTg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: David Miller <davem@davemloft.net>,
        Linux Netdev List <netdev@vger.kernel.org>
To: Or Gerlitz <gerlitz.or@gmail.com>,
        Michael Chan <michael.chan@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f45.google.com ([74.125.83.45]:38767 "EHLO
        mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752861AbdLDWAs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 4 Dec 2017 17:00:48 -0500
Received: by mail-pg0-f45.google.com with SMTP id f12so9189106pgo.5
        for <netdev@vger.kernel.org>; Mon, 04 Dec 2017 14:00:48 -0800 (PST)
In-Reply-To: <CAJ3xEMg5rS+Q=1hV8aMBQJruOH1A7-dScp_8WZwUQTJ7CKcsTg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 2017-12-04 at 23:06 +0200, Or Gerlitz wrote:
> On Mon, Dec 4, 2017 at 8:11 PM, Michael Chan <michael.chan@broadcom.c
> om> wrote:
> 
> > All the logic is already in these 3 drivers in the tree.  You can
> > see
> > the additional logic in any of these drivers.  It's just that these
> > drivers have been using NETIF_F_GRO to turn on this mode in
> > hardware/firmware.
> 
> What happens for tcp encaped by some udp tunnel, does
> the HW know how to GRO that?

Yes it does, at least for common encaps (GRE, SIT, IPIP)