From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next 2/2] veth: allow configuring GSO maximums Date: Mon, 04 Dec 2017 17:04:22 -0800 Message-ID: <1512435862.19682.66.camel@gmail.com> References: <20171201201158.25594-1-sthemmin@microsoft.com> <20171201201158.25594-3-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: David Miller , Linux Kernel Network Developers , Stephen Hemminger To: Cong Wang , Stephen Hemminger Return-path: Received: from mail-pg0-f45.google.com ([74.125.83.45]:46519 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdLEBEZ (ORCPT ); Mon, 4 Dec 2017 20:04:25 -0500 Received: by mail-pg0-f45.google.com with SMTP id b11so9491447pgu.13 for ; Mon, 04 Dec 2017 17:04:25 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2017-12-04 at 16:03 -0800, Cong Wang wrote: > On Fri, Dec 1, 2017 at 12:11 PM, Stephen Hemminger > wrote: > > Veth's can be used in environments (like Azure) where the > > underlying > > network device is impacted by large GSO packets. This patch allows > > gso maximum values to be passed in when creating the device via > > netlink. > > > > In theory, other pseudo devices could also use netlink attributes > > to set GSO maximums but for now veth is what has been observed > > to be an issue. > > It looks odd that you only allow setting them but not dumping them. Dump is already supported/provided by core stack # ip -d link sh dev wlan0 2: wlan0: mtu 1500 qdisc fq state UP mode DORMANT group default qlen 1000     link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff promiscuity 0 addrgenmode none numtxqueues 4 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535