From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type Date: Tue, 05 Dec 2017 18:30:10 +0100 Message-ID: <1512495010.26976.24.camel@sipsolutions.net> References: <20171202202332.10205-1-johannes@sipsolutions.net> <20171205.113145.172521292247335321.davem@davemloft.net> <1512491661.26976.19.camel@sipsolutions.net> <20171205.114106.1013322969674769159.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, j@w1.fi, dsahern@gmail.com To: David Miller Return-path: Received: from s3.sipsolutions.net ([144.76.63.242]:57576 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbdLERaQ (ORCPT ); Tue, 5 Dec 2017 12:30:16 -0500 In-Reply-To: <20171205.114106.1013322969674769159.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2017-12-05 at 11:41 -0500, David Miller wrote: > > There is no reasonable interpretation for what that application is > doing, so I think we can safely call that case as buggy. > > We are only trying to handle the situation where a U8 attribute > is presented as a bonafide U32 or a correct U8. > > Does this make sense? Well the application is buggy, but we don't really know in what way? Perhaps somebody even did the equivalent of nla_put_u32(ATTR, cpu_to_le32(x)) when they noticed it was broken on BE, and end up with a similar case as I had above. I don't think there's a good solution to this, applications must be fixed anyhow. I'm just saying that I'd save the extra code and stay compatible with applications as written today, even if they're now broken on BE - and rely on the warning to fix it. Trying to fix it up seems to have the potential to just break something else. johannes