From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: Uninitialized value in __sk_nulls_add_node_rcu()
Date: Tue, 05 Dec 2017 12:07:07 -0800
Message-ID: <1512504427.25033.0.camel@gmail.com>
References: <CAEfhGiwQe-whM8p1OuLC3WntogmC6AeLS0HPRUcTL85ii8hKmw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: Eric Dumazet <edumazet@google.com>,
        Alexander Potapenko <glider@google.com>,
        David Miller <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>
To: Craig Gallek <kraigatgoog@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f45.google.com ([209.85.214.45]:35195 "EHLO
        mail-it0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751177AbdLEUHJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Dec 2017 15:07:09 -0500
Received: by mail-it0-f45.google.com with SMTP id f143so4443005itb.0
        for <netdev@vger.kernel.org>; Tue, 05 Dec 2017 12:07:09 -0800 (PST)
In-Reply-To: <CAEfhGiwQe-whM8p1OuLC3WntogmC6AeLS0HPRUcTL85ii8hKmw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 2017-12-05 at 14:39 -0500, Craig Gallek wrote:
> On Tue, Dec 5, 2017 at 9:18 AM, Eric Dumazet <eric.dumazet@gmail.com>
> wrote:
> > On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote:
> > > 
> > > +     hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list);
> > 
> > Typo here, this needs sk_nulls_node of course.
> > 
> 
> Thanks Eric, this looks good to me.  The tail insertion is still
> required in udp_lib_get_port for the second layer hash, but not here.
> fwiw, reuseport_dualstack in the selftests directory verifies this
> behavior.  I tried it with your patch (it still passes) and removing
> the udp_lib_get_port path (to make sure it breaks when it should).
> 

Thanks for confirming this, I will send the official patch then ;)