From mboxrd@z Thu Jan 1 00:00:00 1970 From: Solio Sarabia Subject: [PATCH 2/2] veth: allow configuring GSO maximums Date: Tue, 5 Dec 2017 17:14:26 -0800 Message-ID: <1512522866-5544-3-git-send-email-solio.sarabia@intel.com> References: <1512522866-5544-1-git-send-email-solio.sarabia@intel.com> Cc: eric.dumazet@gmail.com, dsahern@gmail.com, kys@microsoft.com, shiny.sebastian@intel.com, solio.sarabia@intel.com, Stephen Hemminger To: netdev@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org Return-path: Received: from mga02.intel.com ([134.134.136.20]:54757 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753336AbdLFBSr (ORCPT ); Tue, 5 Dec 2017 20:18:47 -0500 In-Reply-To: <1512522866-5544-1-git-send-email-solio.sarabia@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Stephen Hemminger Veth's can be used in environments (like Azure) where the underlying network device is impacted by large GSO packets. This patch allows gso maximum values to be passed in when creating the device via netlink. In theory, other pseudo devices could also use netlink attributes to set GSO maximums but for now veth is what has been observed to be an issue. Signed-off-by: Stephen Hemminger Signed-off-by: Solio Sarabia --- drivers/net/veth.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index f5438d0..510c058 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -410,6 +410,26 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, if (ifmp && (dev->ifindex != 0)) peer->ifindex = ifmp->ifi_index; + if (tbp[IFLA_GSO_MAX_SIZE]) { + u32 max_size = nla_get_u32(tbp[IFLA_GSO_MAX_SIZE]); + + if (max_size > GSO_MAX_SIZE) + return -EINVAL; + + peer->gso_max_size = max_size; + dev->gso_max_size = max_size; + } + + if (tbp[IFLA_GSO_MAX_SEGS]) { + u32 max_segs = nla_get_u32(tbp[IFLA_GSO_MAX_SEGS]); + + if (max_segs > GSO_MAX_SEGS) + return -EINVAL; + + peer->gso_max_segs = max_segs; + dev->gso_max_segs = max_segs; + } + err = register_netdevice(peer); put_net(net); net = NULL; -- 2.7.4