From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched Date: Thu, 07 Dec 2017 16:56:12 +0100 Message-ID: <1512662172.7042.14.camel@baylibre.com> References: <20171207142715.32578-1-jbrunet@baylibre.com> <20171207142715.32578-7-jbrunet@baylibre.com> <20171207154943.GI24750@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , Kevin Hilman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Andrew Lunn Return-path: In-Reply-To: <20171207154943.GI24750@lunn.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On Thu, 2017-12-07 at 16:49 +0100, Andrew Lunn wrote: > On Thu, Dec 07, 2017 at 03:27:13PM +0100, Jerome Brunet wrote: > > The PHY performs just as well when left in its default configuration and > > it makes senses because this poke gets reset just after init. > > The only thing which might speak against this, is some bootloader > which sets something other than the default, and here we put it back > to the value it should have. But if you say a reset will put it back > to the default value anyway, this seems save. I was worried about this too bu the bank also gets reset on power down and soft reset, so we won't get bootloader value at this point > > Reviewed-by: Andrew Lunn > > Andrew