From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net: ipv4: fix for a race condition in raw_sendmsg
Date: Sat, 09 Dec 2017 20:30:55 -0800
Message-ID: <1512880255.25033.36.camel@gmail.com>
References: <5a2caf2e.4ce61c0a.5017a.575f@mx.google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: Herbert Xu <herbert@gondor.apana.org.au>
To: simo.ghannam@gmail.com, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f66.google.com ([209.85.160.66]:46290 "EHLO
        mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751343AbdLJEa7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 9 Dec 2017 23:30:59 -0500
Received: by mail-pl0-f66.google.com with SMTP id i6so2646347plt.13
        for <netdev@vger.kernel.org>; Sat, 09 Dec 2017 20:30:59 -0800 (PST)
In-Reply-To: <5a2caf2e.4ce61c0a.5017a.575f@mx.google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sun, 2017-12-10 at 03:50 +0000, simo.ghannam@gmail.com wrote:
> From: Mohamed Ghannam <simo.ghannam@gmail.com>
> 
> inet->hdrincl is racy, and could lead to uninitialized stack pointer
> usage, so its value should be read only once.
> 
> Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com>
> ---
>  net/ipv4/raw.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Thanks a lot for fixing this very serious bug.

Reviewed-by: Eric Dumazet <edumazet@google.com>

Please David add :

Fixes: c008ba5bdc9f ("ipv4: Avoid reading user iov twice after raw_probe_proto_opt")

Thanks !