From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static Date: Tue, 12 Dec 2017 15:20:42 +0100 Message-ID: <1513088442.26438.18.camel@baylibre.com> References: <20171212130311.17185-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Colin King , Andrew Lunn , Florian Fainelli , Carlo Caione , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Return-path: In-Reply-To: <20171212130311.17185-1-colin.king@canonical.com> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote: > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'meson_gxl_read_status' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Indeed, silly mistake, thx for spotting it. Reviewed-by: Jerome Brunet