From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding Date: Wed, 13 Dec 2017 09:52:44 -0800 Message-ID: <1513187564.25033.65.camel@gmail.com> References: <1513164048-21368-1-git-send-email-redmcg@redmandi.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit To: Brendan McGrath , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1513164048-21368-1-git-send-email-redmcg@redmandi.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2017-12-13 at 22:20 +1100, Brendan McGrath wrote: > Currently, when forwarding from a Virtual Interface to a Physical > Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and > the UDP checksum has not been calculated. > This seems a bug then ? CHECKSUM_UNNECESSARY means checksum has been validated. Not that we want it being computed later in the stack. If we force a checksum here, what guarantee do we have packet was not corrupted before we do this ?