From: Joe Perches <joe@perches.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>,
perex@perex.cz, floeff@mathematik.uni-stuttgart.de,
acme@conectiva.com.br
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub
Date: Wed, 13 Dec 2017 17:21:07 -0800 [thread overview]
Message-ID: <1513214467.27409.44.camel@perches.com> (raw)
In-Reply-To: <1513158468-14382-1-git-send-email-baijiaju1990@gmail.com>
On Wed, 2017-12-13 at 17:47 +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> hp100_set_multicast_list (acquire the spinlock)
> hp100_login_to_vg_hub
> schedule_timeout_interruptible --> may sleep
>
> To fix it, schedule_timeout_interruptible is replaced with udelay.
>
> This bug is found by my static analysis tool(DSAC) and checked by my code review.
Are there any current working VG/AnyLan network installations?
I rather doubt it.
prev parent reply other threads:[~2017-12-14 1:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 9:47 [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub Jia-Ju Bai
2017-12-13 21:20 ` David Miller
2017-12-14 3:13 ` Jia-Ju Bai
2017-12-14 3:31 ` Jia-Ju Bai
2017-12-14 3:34 ` David Miller
2017-12-14 3:56 ` Jia-Ju Bai
2017-12-15 11:13 ` Siegfried Loeffler
2017-12-14 1:21 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513214467.27409.44.camel@perches.com \
--to=joe@perches.com \
--cc=acme@conectiva.com.br \
--cc=baijiaju1990@gmail.com \
--cc=floeff@mathematik.uni-stuttgart.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).