From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub Date: Wed, 13 Dec 2017 17:21:07 -0800 Message-ID: <1513214467.27409.44.camel@perches.com> References: <1513158468-14382-1-git-send-email-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Jia-Ju Bai , perex@perex.cz, floeff@mathematik.uni-stuttgart.de, acme@conectiva.com.br Return-path: In-Reply-To: <1513158468-14382-1-git-send-email-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2017-12-13 at 17:47 +0800, Jia-Ju Bai wrote: > The driver may sleep under a spinlock. > The function call path is: > hp100_set_multicast_list (acquire the spinlock) > hp100_login_to_vg_hub > schedule_timeout_interruptible --> may sleep > > To fix it, schedule_timeout_interruptible is replaced with udelay. > > This bug is found by my static analysis tool(DSAC) and checked by my code review. Are there any current working VG/AnyLan network installations? I rather doubt it.