From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: xiyou.wangcong@gmail.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, Tonghao Zhang <xiangxia.m.yue@gmail.com>,
Pavel Emelyanov <xemul@openvz.org>
Subject: [PATCH v7 3/3] sock: Hide unused variable when !CONFIG_PROC_FS.
Date: Thu, 14 Dec 2017 05:51:59 -0800 [thread overview]
Message-ID: <1513259519-32332-3-git-send-email-xiangxia.m.yue@gmail.com> (raw)
In-Reply-To: <1513259519-32332-1-git-send-email-xiangxia.m.yue@gmail.com>
When CONFIG_PROC_FS is disabled, we will not use the prot_inuse
counter. This adds an #ifdef to hide the variable definition in
that case. This is not a bugfix. But we can save bytes when there
are many network namespace.
Cc: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Martin Zhang <zhangjunweimartin@didichuxing.com>
Signed-off-by: Tonghao Zhang <zhangtonghao@didichuxing.com>
---
include/net/netns/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/netns/core.h b/include/net/netns/core.h
index a5e8a66..36c2d99 100644
--- a/include/net/netns/core.h
+++ b/include/net/netns/core.h
@@ -13,8 +13,8 @@ struct netns_core {
#ifdef CONFIG_PROC_FS
int __percpu *sock_inuse;
-#endif
struct prot_inuse __percpu *prot_inuse;
+#endif
};
#endif
--
1.8.3.1
prev parent reply other threads:[~2017-12-14 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 13:51 [PATCH v7 1/3] sock: Change the netns_core member name Tonghao Zhang
2017-12-14 13:51 ` [PATCH v7 2/3] sock: Move the socket inuse to namespace Tonghao Zhang
2017-12-18 19:30 ` David Miller
2017-12-18 21:38 ` Cong Wang
2017-12-19 3:22 ` David Miller
2017-12-19 15:19 ` David Miller
2017-12-14 13:51 ` Tonghao Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513259519-32332-3-git-send-email-xiangxia.m.yue@gmail.com \
--to=xiangxia.m.yue@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox