From: Brian King <brking@linux.vnet.ibm.com>
To: siva.kallam@broadcom.com, prashant@broadcom.com, mchan@broadcom.com
Cc: benjamin.kun@broadcom.com, netdev@vger.kernel.org,
maurosr@linux.vnet.ibm.com, muvic@linux.vnet.ibm.com,
brking@pobox.com, Brian King <brking@linux.vnet.ibm.com>,
stable <stable@vger.kernel.org>
Subject: [PATCH] tg3: Fix rx hang on MTU change with 5717/5719
Date: Fri, 15 Dec 2017 15:21:50 -0600 [thread overview]
Message-ID: <1513372910-32121-1-git-send-email-brking@linux.vnet.ibm.com> (raw)
This fixes a hang issue seen when changing the MTU size from 1500 MTU
to 9000 MTU on both 5717 and 5719 chips. In discussion with Broadcom,
they've indicated that these chipsets have the same phy as the 57766
chipset, so the same workarounds apply. This has been tested by IBM
on both Power 8 and Power 9 systems as well as by Broadcom on x86
hardware and has been confirmed to resolve the hang issue.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/net/ethernet/broadcom/tg3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index de51c21..d09c5a9 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -14225,7 +14225,9 @@ static int tg3_change_mtu(struct net_device *dev, int new_mtu)
/* Reset PHY, otherwise the read DMA engine will be in a mode that
* breaks all requests to 256 bytes.
*/
- if (tg3_asic_rev(tp) == ASIC_REV_57766)
+ if (tg3_asic_rev(tp) == ASIC_REV_57766 ||
+ tg3_asic_rev(tp) == ASIC_REV_5717 ||
+ tg3_asic_rev(tp) == ASIC_REV_5719)
reset_phy = true;
err = tg3_restart_hw(tp, reset_phy);
--
1.8.3.1
next reply other threads:[~2017-12-15 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 21:21 Brian King [this message]
2017-12-19 15:25 ` [PATCH] tg3: Fix rx hang on MTU change with 5717/5719 David Miller
-- strict thread matches above, loose matches on Subject: below --
2017-12-17 4:26 Siva Reddy Kallam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513372910-32121-1-git-send-email-brking@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=benjamin.kun@broadcom.com \
--cc=brking@pobox.com \
--cc=maurosr@linux.vnet.ibm.com \
--cc=mchan@broadcom.com \
--cc=muvic@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox