From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro Date: Sun, 17 Dec 2017 08:25:00 -0800 Message-ID: <1513527900.31581.27.camel@perches.com> References: <20171217161534.2446-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, arkadis@mellanox.com, idosch@mellanox.com, mlxsw@mellanox.com To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from smtprelay0089.hostedemail.com ([216.40.44.89]:59685 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757142AbdLQQZD (ORCPT ); Sun, 17 Dec 2017 11:25:03 -0500 In-Reply-To: <20171217161534.2446-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2017-12-17 at 17:15 +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Add "spectrum" string prefix macro for error strings. [] > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c [] > @@ -4168,13 +4168,11 @@ mlxsw_sp_master_lag_check(struct mlxsw_sp *mlxsw_sp, > u16 lag_id; > > if (mlxsw_sp_lag_index_get(mlxsw_sp, lag_dev, &lag_id) != 0) { > - NL_SET_ERR_MSG(extack, > - "spectrum: Exceeded number of supported LAG devices"); > + NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "Exceeded number of supported LAG devices"); Perhaps use NL_SET_ERR_MSG_MOD instead. etc...