From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: [PATCH iproute2 0/3] Improve iplink index, alias and name parameters handling Date: Mon, 18 Dec 2017 20:54:05 +0200 Message-ID: <1513623248-7689-1-git-send-email-serhe.popovych@gmail.com> To: netdev@vger.kernel.org Return-path: Received: from mail-lf0-f53.google.com ([209.85.215.53]:36991 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760199AbdLRSzA (ORCPT ); Mon, 18 Dec 2017 13:55:00 -0500 Received: by mail-lf0-f53.google.com with SMTP id a12so18934030lfe.4 for ; Mon, 18 Dec 2017 10:54:59 -0800 (PST) Received: from tuxracer.localdomain ([2a01:6d80::195:20:96:53]) by smtp.gmail.com with ESMTPSA id y26sm1916932lfk.85.2017.12.18.10.54.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Dec 2017 10:54:58 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: In this series I present following improvements: 1) Check index is greather than zero and forbid specifying it multiple times in iplink_parse(). Use 0 instead of -1 as special value in iplink_modify(). 2) Do not stop parameters processing after alias given. Check alias length does not exceed IFALIASZ - 1. 3) Drop redundant name parameter length checks in iplink_vxcan.c and link_veth.c. See individual patch description message for details. Thanks, Serhii Serhey Popovych (3): iplink: Improve index parameter handling iplink: Process "alias" parameter correctly iplink: Kill redundant network device name checks ip/iplink.c | 21 ++++++++++----------- ip/iplink_vxcan.c | 8 +++----- ip/link_veth.c | 8 +++----- 3 files changed, 16 insertions(+), 21 deletions(-) -- 1.7.10.4