From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name" Date: Tue, 19 Dec 2017 17:15:06 +0100 Message-ID: <1513700106.26145.16.camel@sipsolutions.net> References: <20171202074155.29146-1-johannes@sipsolutions.net> <87vah29a1m.fsf@concordia.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , Jouni Malinen , Rasmus Villemoes , "linuxppc-dev@lists.ozlabs.org" To: Michael Ellerman Return-path: Received: from s3.sipsolutions.net ([144.76.63.242]:38206 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbdLSQPJ (ORCPT ); Tue, 19 Dec 2017 11:15:09 -0500 In-Reply-To: <87vah29a1m.fsf@concordia.ellerman.id.au> Sender: netdev-owner@vger.kernel.org List-ID: Hi, > This revert seems to have broken networking on one of my powerpc > machines, according to git bisect. Fun! TBH, I only looked at the immediate problem we ran into, and reverted what was causing it. I don't think we saw the follow-up problem you're seeing. > The symptom is DHCP fails and I don't get a link, I didn't dig any > further than that. I can if it's helpful. > > I think the problem is that 87c320e51519 ("net: core: dev_get_valid_name > is now the same as dev_alloc_name_ns") only makes sense while > d6f295e9def0 remains in the tree. > > ie. before the entire series, dev_get_valid_name() would return EEXIST, > and that was retained when 87c320e51519 was merged, but now that > d6f295e9def0 has been reverted dev_get_valid_name() is returning ENFILE. > > I can get the network up again if I also revert 87c320e51519 ("net: > core: dev_get_valid_name is now the same as dev_alloc_name_ns"), or with > the gross patch below. Makes sense. I guess that should be reverted too then, or even your "gross" patch applied. johannes