From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1] net: pasemi: Replace mac address parsing Date: Tue, 19 Dec 2017 21:27:30 +0200 Message-ID: <1513711650.7000.213.camel@linux.intel.com> References: <20171219183103.74530-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit To: Randy Dunlap , Kees Cook , Eric Dumazet , "David S. Miller" , netdev@vger.kernel.org Return-path: Received: from mga05.intel.com ([192.55.52.43]:55252 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbdLST3E (ORCPT ); Tue, 19 Dec 2017 14:29:04 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2017-12-19 at 11:19 -0800, Randy Dunlap wrote: > On 12/19/2017 10:31 AM, Andy Shevchenko wrote: > > Replace sscanf() with mac_pton(). > > > > Signed-off-by: Andy Shevchenko > > You don't need to select GENERIC_NET_UTILS for that? It's done by CONFIG_NET. > > > --- > > drivers/net/ethernet/pasemi/pasemi_mac.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c > > b/drivers/net/ethernet/pasemi/pasemi_mac.c > > index c9a55b774935..07a2eb3781b1 100644 > > --- a/drivers/net/ethernet/pasemi/pasemi_mac.c > > +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c > > @@ -212,9 +212,7 @@ static int pasemi_get_mac_addr(struct pasemi_mac > > *mac) > > return -ENOENT; > > } > > > > - if (sscanf(maddr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx", > > - &addr[0], &addr[1], &addr[2], &addr[3], > > &addr[4], &addr[5]) > > - != ETH_ALEN) { > > + if (!mac_pton(maddr, addr)) { > > dev_warn(&pdev->dev, > > "can't parse mac address, not > > configuring\n"); > > return -EINVAL; > > > > -- Andy Shevchenko Intel Finland Oy