From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ilya Lesokhin <ilyal@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "davejwatson@fb.com" <davejwatson@fb.com>,
"tom@herbertland.com" <tom@herbertland.com>,
"hannes@stressinduktion.org" <hannes@stressinduktion.org>,
Boris Pismenny <borisp@mellanox.com>,
Aviad Yehezkel <aviadye@mellanox.com>,
Liran Liss <liranl@mellanox.com>
Subject: Re: [PATCH v3 net-next 1/6] tcp: Add clean acked data hook
Date: Tue, 19 Dec 2017 11:28:51 -0800 [thread overview]
Message-ID: <1513711731.64874.6.camel@gmail.com> (raw)
In-Reply-To: <AM4PR0501MB2723A3177E58E20777689A56D40F0@AM4PR0501MB2723.eurprd05.prod.outlook.com>
On Tue, 2017-12-19 at 19:21 +0000, Ilya Lesokhin wrote:
> > 1) tcp_ack() is already very expensive.
> >
>
> I'm not sure how what we should do with that comment. We need
> Some trigger to free TLS records. tcp_ack seemed like a reasonable
> Trigger.
TLS records should be attached to skbs ?
It seems more reasonable to free TLS when skb are freed, and not in
general tcp_ack() path.
>
> > 2) Since you do not pass any state here, this looks very suspicious to
> > me.
> >
>
> The state we need is the acknowledged sequence and it located in the socket.
> https://github.com/Mellanox/tls-offload/blob/tls_device_v3/net/tls/tls_device.c#L157
So it looks like TCP stack is bleeding all over the places ?
So in the future, a change in TCP stack will have to make sure we do
not break net/tls/... compilation.
Not pretty.
next prev parent reply other threads:[~2017-12-19 19:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 11:10 [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 1/6] tcp: Add clean acked data hook Ilya Lesokhin
2017-12-19 19:13 ` Eric Dumazet
2017-12-19 19:21 ` Ilya Lesokhin
2017-12-19 19:28 ` Eric Dumazet [this message]
2017-12-19 19:43 ` Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 2/6] net: Rename and export copy_skb_header Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 3/6] net: Add SW fallback infrastructure for offloaded sockets Ilya Lesokhin
2017-12-18 19:18 ` Marcelo Ricardo Leitner
2017-12-19 7:51 ` Ilya Lesokhin
2017-12-19 15:05 ` Marcelo Ricardo Leitner
2017-12-19 19:12 ` Eric Dumazet
2017-12-19 19:15 ` Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 4/6] net: Add TLS offload netdev ops Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 5/6] net: Add TLS TX offload features Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure Ilya Lesokhin
2017-12-18 19:53 ` Marcelo Ricardo Leitner
2017-12-19 7:31 ` Ilya Lesokhin
2017-12-19 15:11 ` Marcelo Ricardo Leitner
2017-12-19 15:38 ` Ilya Lesokhin
2017-12-19 16:18 ` Marcelo Ricardo Leitner
2017-12-19 7:00 ` kbuild test robot
2017-12-19 7:01 ` kbuild test robot
2017-12-19 8:17 ` [RFC PATCH] tls: tls_sw_fallback() can be static kbuild test robot
2017-12-19 8:17 ` [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure kbuild test robot
2017-12-18 17:10 ` [PATCH v3 net-next 0/6] " Jiri Pirko
2017-12-19 10:30 ` Jiri Pirko
2017-12-20 8:28 ` Boris Pismenny
2017-12-20 10:08 ` Jiri Pirko
2017-12-20 10:15 ` Or Gerlitz
2017-12-20 10:31 ` Or Gerlitz
2017-12-20 16:12 ` David Miller
2017-12-20 16:23 ` Ilya Lesokhin
2017-12-20 16:36 ` David Miller
2017-12-20 19:12 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513711731.64874.6.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=ilyal@mellanox.com \
--cc=liranl@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).