From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christian Lamparter <chunkeey@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode
Date: Thu, 21 Dec 2017 09:04:35 +1100 [thread overview]
Message-ID: <1513807475.2743.17.camel@kernel.crashing.org> (raw)
In-Reply-To: <5154461.jTBeEfsTQW@debian64>
On Wed, 2017-12-20 at 22:07 +0100, Christian Lamparter wrote:
>
> > will read this and say "Oh the function tests against these weird
> > PHY_MODE_* aliases, but the helper function phy_interface_mode_is_rgmii()
> > tests against PHY_INTERFACE_MODE_*, what is going on?"
> >
> > I hate to do this to you, but please get rid of these confusing and
> > completely unnecessary PHY_MODE_* CPP aliases first, and just use the
> > proper PHY_INTERFACE_MODE_* values consistently.
>
> Yeah, I can do that. no problem.
>
> Question is, should I also replace the rgmii_mode_name() with phy_modes() too?
>
> The only user of rgmii_mode_name() is this notice printk in rgmii_attach():
> <http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/ibm/emac/rgmii.c#L117>
Yup, this is all pre-hisorical gunk, feel free to replace it.
Cheers,
Ben.
prev parent reply other threads:[~2017-12-20 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 16:02 [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode Christian Lamparter
2017-12-20 20:10 ` David Miller
2017-12-20 21:07 ` Christian Lamparter
2017-12-20 21:20 ` David Miller
2017-12-20 22:04 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513807475.2743.17.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).