From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yafang Shao Subject: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state Date: Fri, 22 Dec 2017 23:37:13 +0800 Message-ID: <1513957033-24100-1-git-send-email-laoar.shao@gmail.com> Cc: netdev@vger.kernel.org, Yafang Shao To: davem@davemloft.net Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:45992 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbdLVPhY (ORCPT ); Fri, 22 Dec 2017 10:37:24 -0500 Received: by mail-pf0-f194.google.com with SMTP id u19so15418692pfa.12 for ; Fri, 22 Dec 2017 07:37:24 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: There's a space character missed in the printk messages. This error should be prevented with checkscript.pl, but it couldn't caught by running with "checkscript.pl -f xxxx.patch", that's what I had run before. What a carelessness. Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint") Signed-off-by: Yafang Shao --- include/trace/events/sock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h index 3b9094a..598399da 100644 --- a/include/trace/events/sock.h +++ b/include/trace/events/sock.h @@ -160,7 +160,7 @@ } ), - TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4" + TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 " "saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s", show_inet_protocol_name(__entry->protocol), __entry->sport, __entry->dport,