From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered Date: Thu, 28 Dec 2017 21:30:20 +0000 Message-ID: <1514496620-69953-4-git-send-email-netanel@amazon.com> References: <1514496620-69953-1-git-send-email-netanel@amazon.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Netanel Belgazal , , , , , , , , , To: , Return-path: Received: from smtp-fw-9102.amazon.com ([207.171.184.29]:62205 "EHLO smtp-fw-9102.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754495AbdL1Vao (ORCPT ); Thu, 28 Dec 2017 16:30:44 -0500 In-Reply-To: <1514496620-69953-1-git-send-email-netanel@amazon.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Netanel Belgazal netif_carrier_off() should be called only after register netdev. Move the function's call after the registration. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index fbe21a817bd8..ee50c56765a4 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -3276,14 +3276,14 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent) memcpy(adapter->netdev->perm_addr, adapter->mac_addr, netdev->addr_len); - netif_carrier_off(netdev); - rc = register_netdev(netdev); if (rc) { dev_err(&pdev->dev, "Cannot register net device\n"); goto err_rss; } + netif_carrier_off(netdev); + INIT_WORK(&adapter->reset_task, ena_fw_reset_device); adapter->last_keep_alive_jiffies = jiffies; -- 2.7.3.AMZN