From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>,
"SF Markus Elfring" <elfring@users.sourceforge.net>
Cc: linux-netdev <netdev@vger.kernel.org>,
Andy Gospodarek <andy@greyhouse.net>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr()
Date: Wed, 03 Jan 2018 13:58:32 -0800 [thread overview]
Message-ID: <1515016712.131759.0.camel@gmail.com> (raw)
In-Reply-To: <CAF2d9jh1EHUx3BzWghBWRAZt4acO6W-_eUXtD7dk2YBJZfuwsg@mail.gmail.com>
On Wed, 2018-01-03 at 11:28 -0800, Mahesh Bandewar (महेश बंडेवार)
wrote:
> On Wed, Jan 3, 2018 at 12:45 AM, SF Markus Elfring
> <elfring@users.sourceforge.net> wrote:
> > > > Omit an extra message for a memory allocation failure in this function.
> > > >
> > > > This issue was detected by using the Coccinelle software.
> > > >
> > >
> > > What is the issue with this message?
> >
> > * Is it redundant?
> >
> > * Would a Linux allocation failure report be already sufficient here?
> >
>
> If you see 8 out of 9 call sites in this file ignore the return value.
> This message in the log could give a clue when debugging. Unless it's
> spamming it's not harmful, or is it?
A failed kzalloc() would already give a complete stack trace.
Really the pr_err() adds no value here.
next prev parent reply other threads:[~2018-01-03 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 16:07 [PATCH] bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr() SF Markus Elfring
2018-01-03 7:00 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-03 8:45 ` SF Markus Elfring
2018-01-03 19:28 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-03 21:58 ` Eric Dumazet [this message]
2018-01-04 8:19 ` bonding: Completion of error handling around bond_update_slave_arr() SF Markus Elfring
2018-01-04 18:52 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-04 21:41 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515016712.131759.0.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=elfring@users.sourceforge.net \
--cc=j.vosburgh@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).