From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH] nl80211: Check for the required netlink attribute presence Date: Thu, 04 Jan 2018 16:09:01 +0100 Message-ID: <1515078541.10342.30.camel@sipsolutions.net> References: <1514948431-20893-1-git-send-email-flank3rsky@gmail.com> (sfid-20180103_040046_373329_293E7D92) Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Hao Chen Return-path: In-Reply-To: <1514948431-20893-1-git-send-email-flank3rsky@gmail.com> (sfid-20180103_040046_373329_293E7D92) Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2018-01-03 at 11:00 +0800, Hao Chen wrote: > nl80211_nan_add_func() does not check if the required attribute > NL80211_NAN_FUNC_FOLLOW_UP_DEST is present when processing > NL80211_CMD_ADD_NAN_FUNCTION request. This request can be issued > by users with CAP_NET_ADMIN privilege and may result in NULL dereference > and a system crash. Add a check for the required attribute presence. Applied, thanks. johannes