From: Eric Dumazet <eric.dumazet@gmail.com>
To: Natale Patriciello <natale.patriciello@gmail.com>,
netdev@vger.kernel.org
Cc: Carlo Augusto Grazia <carloaugusto.grazia@unimore.it>
Subject: Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ
Date: Fri, 05 Jan 2018 03:53:46 -0800 [thread overview]
Message-ID: <1515153226.131759.8.camel@gmail.com> (raw)
In-Reply-To: <20180105113256.14835-4-natale.patriciello@gmail.com>
On Fri, 2018-01-05 at 12:32 +0100, Natale Patriciello wrote:
> The original TSQ algorithm limits the number of packets in qdisc/devices to
> two packets / or ~1 ms. With this commit, two sysctl knobs are added to
> allow tuning the number of packets or the ms value.
>
> Signed-off-by: Natale Patriciello <natale.patriciello@gmail.com>
> Cc: Carlo Augusto Grazia <carloaugusto.grazia@unimore.it>
> Tested-by: Carlo Augusto Grazia <carloaugusto.grazia@unimore.it>
> ---
NACK
You provide dubious reasons, and no real tests done on various
hardwares.
We do not want sysctls that wont solve the issue you try to address.
Your patch series comes too late.
A linux host can have one 10Gbit NIC and a wifi adapter, they require
different tunings.
This is why we added sk_pacing_shift_update().
If this needs refinement, lets talk.
next prev parent reply other threads:[~2018-01-05 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 11:32 [RFC PATCH 0/3] tcp: allow user and drivers to tweak TSQ logic through sysctl knobs Natale Patriciello
2018-01-05 11:32 ` [RFC PATCH 1/3] Revert "tcp: allow drivers to tweak TSQ logic" Natale Patriciello
2018-01-05 11:44 ` Eric Dumazet
2018-01-05 15:26 ` David Miller
2018-01-05 11:32 ` [RFC PATCH 2/3] tcp: Negative values of sysctl_tcp_limit_output_bytes disable TSQ Natale Patriciello
2018-01-05 11:43 ` Eric Dumazet
2018-01-05 11:32 ` [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ Natale Patriciello
2018-01-05 11:53 ` Eric Dumazet [this message]
2018-01-06 19:22 ` Natale Patriciello
2018-01-09 19:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515153226.131759.8.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=carloaugusto.grazia@unimore.it \
--cc=natale.patriciello@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).